Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support matrix of features supported of Ceph CSI version #298

Closed
wants to merge 2 commits into from
Closed

Add support matrix of features supported of Ceph CSI version #298

wants to merge 2 commits into from

Conversation

poornimag
Copy link

Signed-off-by: Poornima G pgurusid@redhat.com

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 3, 2019 •
edited
Loading

Thanks, @poornimag for the PR.

Fixes #268

@leseb PTAL

Madhu-1
Madhu-1 reviewed Apr 3, 2019
View reviewed changes
README.md Outdated
## Support Matrix
Here is the matrix that describes the features supported by the different versions of Ceph CSI driver

| | Features | CSI driver<br>Version |Kubeernetes<br>Version|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubeernetes to Kubernetes

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 3, 2019

@poornimag can you update the table for v0.3.0 driver also

Add support matrix of features supported of Ceph CSI version
e115d3f 
Signed-off-by: Poornima G <pgurusid@redhat.com>
leseb
leseb reviewed Apr 3, 2019
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the access modes? RWO, RWX etc?

@poornimag
Copy link
Author

CI is failng with "./README.md:1: MD033 Inline HTML". I think that's due to the "CSI driver
Version", this is the only way to list two lines in a single cell in markdown table. I can get rid of the
and will have a long column heading. Should i do that? or allow html in readme?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 3, 2019

we have 2 options, disable the rule or
use pure markdown instead of HTML

@poornimag will this helps https://talk.commonmark.org/t/tables-in-pure-markdown/81/145

humblec
humblec reviewed Apr 3, 2019
View reviewed changes
README.md
@@ -20,6 +20,23 @@ CephFS CSI plugins, see documentation in `docs/`.

For example usage of RBD and CephFS CSI plugins, see examples in `examples/`.

## Support Matrix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poornimag ideally we should have these columns :
Branch/CSI driver Version, CSI Spec , variants like RBD and CephFS, Kubernetes version

@humblec
Copy link
Collaborator

humblec commented Apr 3, 2019

@poornimag ideally we should have these columns :
Branch/CSI driver Version, CSI Spec , variants like RBD and CephFS, Kubernetes version

@leseb
Copy link
Member

leseb commented Apr 3, 2019

Should wait for #297

@Madhu-1 Madhu-1 added the DNM DO NOT MERGE label Apr 3, 2019
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 3, 2019

added DNM label to avoid accidental merging

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 4, 2019

can you send this PR to master branch? from now onwards we will be using master for csiv1.0 development, Thanks

@wilmardo
Copy link
Contributor

wilmardo commented Apr 4, 2019

Also closes #268 right?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 4, 2019

Also closes #268 right?

yes

@humblec
Copy link
Collaborator

humblec commented Apr 24, 2019

@poornimag Can you please correct the tests?

@poornimag
Copy link
Author

@humblec sent another pr..., #315 for master

@poornimag poornimag closed this Apr 24, 2019
@Madhu-1 Madhu-1 mentioned this pull request Jun 10, 2019
Closed
iPraveenParihar pushed a commit to iPraveenParihar/ceph-csi that referenced this pull request May 8, 2024
@openshift-merge-bot
Merge pull request ceph#298 from Rakshith-R/BZ-snap-dead
5400d8a 
BUG 2264900: rbd: add ParentInTrash parameter in rbdImage struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb left review comments

@humblec humblec humblec left review comments

@Madhu-1 Madhu-1 Madhu-1 left review comments

Assignees
No one assigned
Labels
DNM DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@poornimag @Madhu-1 @humblec @leseb @wilmardo